[
https://issues.apache.org/jira/browse/CONNECTORS-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959455#comment-13959455
]
Karl Wright commented on CONNECTORS-911:
----------------------------------------
bq. q1) In this mapping I don't see //No Retries
HttpClientBuilder.setRetryHandler(new HttpRequestRetryHandler() … is this okay?
The purpose of the retry handler was to disable retries. But earlier in the
diff (which you didn't include), I explicitly set .disableRetries(true), which
should do the same thing, I believe.
bq. q2) Does HttpClientBuilder.setRequestExecutor(new
HttpRequestExecutor(socketTimeout)) correspond to
params.setIntParameter(CoreProtocolPNames.WAIT_FOR_CONTINUE,socketTimeout)?
Should I use it in solrconnector.patch?
Yes, according to Oleg in the httpClient project. I asked how to replace the
parameter, and this was what he said to do. But it is only applicable when
setExpectContinue(true) is set; you will need to do it only if the solr
connector enables expect/continue.
> Work on removing HttpClient 4.3 deprecation warnings
> ----------------------------------------------------
>
> Key: CONNECTORS-911
> URL: https://issues.apache.org/jira/browse/CONNECTORS-911
> Project: ManifoldCF
> Issue Type: Task
> Components: Elastic Search connector, Framework crawler agent, JIRA
> connector, Lucene/SOLR connector, OpenSearchServer connector, RSS connector,
> Web connector, Wiki connector
> Affects Versions: ManifoldCF 1.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.6
>
> Attachments: CONNECTORS-911.patch, SolrConnector.patch,
> SolrConnector.patch
>
>
> HttpClient 4.3 deprecates pretty much the entire way you used to build
> httpclient instances; fixing this requires a lot of work in ManifoldCF.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
