[
https://issues.apache.org/jira/browse/CONNECTORS-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958729#comment-13958729
]
Karl Wright commented on CONNECTORS-911:
----------------------------------------
Hi Ahmet,
Have a look at the diff you posted:
{code}
- params.setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE,true);
- params.setIntParameter(CoreProtocolPNames.WAIT_FOR_CONTINUE,socketTimeout);
- params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
- params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);
- params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,socketTimeout);
-
params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,connectionTimeout);
- params.setBooleanParameter(ClientPNames.HANDLE_REDIRECTS,true);
- DefaultHttpClient localClient = new
DefaultHttpClient(connectionManager,params);
+ RequestConfig.Builder requestBuilder = RequestConfig.custom()
+ .setCircularRedirectsAllowed(true)
+ .setSocketTimeout(socketTimeout)
+ .setStaleConnectionCheckEnabled(false)
+ .setExpectContinueEnabled(true)
+ .setConnectTimeout(connectionTimeout)
+ .setConnectionRequestTimeout(socketTimeout);
{code}
StaleConnectionCheck in the existing code is currently set to "true".
> Work on removing HttpClient 4.3 deprecation warnings
> ----------------------------------------------------
>
> Key: CONNECTORS-911
> URL: https://issues.apache.org/jira/browse/CONNECTORS-911
> Project: ManifoldCF
> Issue Type: Task
> Components: Elastic Search connector, Framework crawler agent, JIRA
> connector, Lucene/SOLR connector, OpenSearchServer connector, RSS connector,
> Web connector, Wiki connector
> Affects Versions: ManifoldCF 1.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.6
>
> Attachments: CONNECTORS-911.patch, SolrConnector.patch
>
>
> HttpClient 4.3 deprecates pretty much the entire way you used to build
> httpclient instances; fixing this requires a lot of work in ManifoldCF.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
