My overall list of things to solve before the branch is ready to be merged into develop:
* Should be the GeoSPARQL support optional (configuration, independent artifact, etc)? * Solve the permissions' issue regarding CREATE EXTENSION usage by a regular db user. * Upgrade script does not look be automatically triggered at boot time on existing databases. >From my side, besides those issues that we'll solve later during the integration phase, regarding the implementation itself the project is ready, legally and technically speaking. Please, send a pull request via github and attach the patch to the jira issue for granting intellectual property to ASF over the code base. Congratulations, Francisco! On Thu, Aug 20, 2015 at 11:28 AM, Sergio Fernández <[email protected]> wrote: > Another detail I've realized testing more setups is that the 'CREATE > EXTENSION' statement requires superuser privileges in Postgres: > > 11:15:56.778 ERROR - Error executing: CREATE EXTENSION postgis > 11:15:56.778 ERROR - org.postgresql.util.PSQLException: ERROR: permission > denied to create extension "postgis" > > For the moment I added that prerequisite to the documentation: > > > https://wiki.apache.org/marmotta/MARMOTTA-584/UserDocumentation#Prerequisites > > but I'd like to eventually get a solution for that (many environments > where Marmotta run would never fulfill it). > > > On Thu, Aug 20, 2015 at 9:27 AM, Sergio Fernández <[email protected]> > wrote: > >> The question is wherever we make the upgrade scrips run only if the >> extension is installed, or we just move the geosparql support to a separate >> maven artifact. >> >> What other people would prefer? >> >> On Wed, Aug 19, 2015 at 6:56 PM, Sergio Fernández <[email protected]> >> wrote: >> >>> First test I wanted to do (starting with a clean environment, no postgis >>> installed, small db) the schema upgrade fails. Find log attached. I'll go >>> though it with more time and provide you detailed feedback. >>> >>> On Wed, Aug 19, 2015 at 6:24 PM, Sergio Fernández <[email protected]> >>> wrote: >>> >>>> Hi Francisco, >>>> >>>> On Wed, Aug 19, 2015 at 6:14 PM, FRANCISCO XAVIER SUMBA TORAL < >>>> [email protected]> wrote: >>>>> >>>>> I have understood that to apply the patch. The code must compile and >>>>> does what it claims in the issue and, all license header must be in place. >>>>> Then Have I to apply the patch after two days? >>>>> >>>> >>>> The current path looks fine. I just want some time to check some >>>> things. I'll come back to you as soon as I finish my last review, and then >>>> you can attach the patch to the issue as formal submission of your work. >>>> >>>> >>>>> For sure, It would be great. Here I can gain experience and contribute >>>>> to people with a long career. So for me and other people involved in the >>>>> project it would be a honor. >>>> >>>> >>>> That would be great! Let's keep talking. >>>> >>>> Cheers, >>>> >>>> >>>> -- >>>> Sergio Fernández >>>> Partner Technology Manager >>>> Redlink GmbH >>>> m: +43 6602747925 >>>> e: [email protected] >>>> w: http://redlink.co >>>> >>> >>> >>> >>> -- >>> Sergio Fernández >>> Partner Technology Manager >>> Redlink GmbH >>> m: +43 6602747925 >>> e: [email protected] >>> w: http://redlink.co >>> >> >> >> >> -- >> Sergio Fernández >> Partner Technology Manager >> Redlink GmbH >> m: +43 6602747925 >> e: [email protected] >> w: http://redlink.co >> > > > > -- > Sergio Fernández > Partner Technology Manager > Redlink GmbH > m: +43 6602747925 > e: [email protected] > w: http://redlink.co > -- Sergio Fernández Partner Technology Manager Redlink GmbH m: +43 6602747925 e: [email protected] w: http://redlink.co
