Hi, On Thu, Aug 20, 2015 at 10:37 PM, Rob Vesse <[email protected]> wrote:
> On 20/08/2015 12:41, "Sergio Fernández" <[email protected]> wrote: > > >Maybe I explain it wrong. As I commented in the commit > > > https://github.com/cuent/marmotta/commit/498265077af240956b9caea090ae9895e > >ac35c54 > >the patch must not be in the source code repository, but attached to > >the MARMOTTA-584 jira issue as a formal grant. > > Why? > In that commit he added a patch file to the PR. That file is redundant, and not useful at all. > Is this a GSoC specific restriction > > The Apache License specifically states that any contributions are > implicitly under the Apache License unless the contributor explicitly > states otherwise so unless there is a GSoC specific requirement a pull > request should be more than sufficient especially if you have GitHub PR > integration enabled so the JIRA will be automatically linked with the PR > No, no GSoC specific, just old-school ip grant. I wrote that methodology before we had the github integration in place. Although personally I like to have stored the patch in ASF infrastructure, even if I'll use the PR to get the source contribution. -- Sergio Fernández Partner Technology Manager Redlink GmbH m: +43 6602747925 e: [email protected] w: http://redlink.co
