Op Fri, 11 Dec 2015 22:01:11 +0100 schreef Christian Schulte
<[email protected]>:
Am 12/11/15 um 20:18 schrieb Robert Scholte:
Hi Christian,
first of all: welcome!
about this commit: It took a while before I understood the term 'ssi'.
ssi is an abbreviation, not that clear and IMHO it suggest that this
page
includes dynamic content fro a server, making this content dynamic as
well. That's not what's happening here, right?
How about renaming it to remoteInclude?
I wasn't sure how to name it since it's just a special handling of
comments starting with a '#' character. That need not be server side
include directives. Maybe the method should just be named
'directive( String directive )'
with the logic of any comment starting with a '#' character being
interpreted as some directive and the directive being the trimmed
comment with the '#' character removed. WDYT?
Already better. And don't mind adding javadoc/comments to better explain
its purpose ;)
In general it is good habit to add @since on new (public) methods.
thanks,
Robert
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
