what means "a directive" in markdown? fml? confluence? LaTex? xdoc? I know "directive" word is more generic than "ssi", but the only useful case I know is when generated html is put on a web server that supports such directives then just handling this special comment on xhtml Sink implementation looks an adapted hack IMHO
Enhancing Sink API is not forbidden: it just requires to have a good meaning in most supported formats [1], both when parsing and generating markup Regards, Hervé [1] http://maven.apache.org/doxia/references/index.html Le samedi 12 décembre 2015 11:42:22 Christian Schulte a écrit : > Am 12/12/15 um 11:20 schrieb Hervé BOUTEMY: > > is an API change in Doxia Sink API really necessary to add this > > HTML-specific feature (in very specific context)? > > Not really that HTML-specific any more. I just renamed the method from > 'ssi' to 'directive' locally. > > > Because whatever how the method is named, it won't have general meaning > > for > > most parsers and sink implementations > > Depends on how it is used. It's just a comment starting with a '#' > character which is handled differently than comments not starting with > that character. > > > notice that this API change was detected and the CI is now failing... > > Noticed it. Nobody can ever enhance the Sink API? > > > And instead of accepting this Sink API change, I would prefer to avoid it > > for this feature > > If a new method cannot be added to the Sink API, the only option would > be to handle the directives in every implementation of the following method. > > /** > * Add a comment. > * > * @param comment The comment to write. > * @since 1.1 > */ > void comment( String comment ); > > So every Sink implementation would need to start parsing comments then. > I'd like to avoid that. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
