Am 2015-12-11 um 22:01 schrieb Christian Schulte:
Am 12/11/15 um 20:18 schrieb Robert Scholte:
Hi Christian,
first of all: welcome!
about this commit: It took a while before I understood the term 'ssi'.
ssi is an abbreviation, not that clear and IMHO it suggest that this page
includes dynamic content fro a server, making this content dynamic as
well. That's not what's happening here, right?
How about renaming it to remoteInclude?
I wasn't sure how to name it since it's just a special handling of
comments starting with a '#' character. That need not be server side
include directives. Maybe the method should just be named
'directive( String directive )'
with the logic of any comment starting with a '#' character being
interpreted as some directive and the directive being the trimmed
comment with the '#' character removed. WDYT?
I have anticipated such a discussion. That is why I recommended to
improve the comment parsing rather than adding custom support for SSIs.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
