Hi Benedikt, I am fine now after my illness, thx. I am finishing branch SUREFIRE-1262_2. Just to add few more tests and then I will cut a release. I want to add a fix for SUREFIRE-1374 which would be fast to do. Then I am ready for you and JUnit5.
I have questions regarding our JUnit 5 Surefire Provider implemented in Surefire. Is it implemented exactly in the same like the origin by junit5 team? I am asking because I saw the implementation made by junit5 team and it is not like our *JUnitCoreProvider*. This means that they do not map method <-> Thread in *RunListener *and thus the provider would not associate test report logs and Thread properly and logs will be mixed. Next question is regarding the feature re-run. It also exists in *JUnitCoreProvider *and *JUnit4Provider*. Does it exist in our provider too. Also we need to have a feature where JUnit execution is stopped which can be configured by *skipAfterFailureCount *in POM. We have implementation in Surefire provider: notifier.asFailFast( isFailFast() ); Regarding logger in forked provider, which has to do with parallel exec, I think the logs go to the dump file instead of reports file, because STDOUT is not wrapped in JUnit5's implementation and this should be called: startCapture( listener ) See my questions in https://github.com/xwiki/xwiki-platform/commit/ 5258a22301977a7d1ee7276cdd81af7641f4f5ac Do we have integration tests for these features? Cheers Tibor On Sat, Sep 30, 2017 at 10:34 AM, Benedikt Ritter <[email protected]> wrote: > Hello, > > for over a year now I’m trying to help getting JUnit 5 support into Maven > Surefire. This has been hard since Tibor seems to be the only one > maintaining Maven Surefire and he had to come with other things. > > For this reason I’d like to ask other Maven maintainers to help with the > JUnit 5 support. I’m happy to do the work, but I’m constantly blocked by > obscure build failures which I’m unable to resolve myself or by lack of > code review und merge of changes. > > - Work on JUnit5 support is currently done in the junit5 branch. > - I have drafted a Provider Lookup implementation in the junit5 branch, > but I don’t know whether it works because I can’t get the integration tests > running > - There is an open PR to merge the master branch back into junit5 branch, > but it has build failures I don’t understand [1] > > Please help! > Cheers, > Benedikt > > [1] https://github.com/apache/maven-surefire/pull/165 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
