Il gio 3 gen 2019, 22:37 Tibor Digana <tibordig...@apache.org> ha scritto:
> Why the build cannot be triggered on GitHub or PR? > It's only a URL. > You are right, github gives special refs which represents the branch of the forked repo, like pull/123/head. The problem is that our CI is configured for gitbox and not for github, so we don't have those special refs Enrico If you see the frequency of PRs in Surefire, 1 or 2 PRs/month, this should > not be a problem since the Windows build takes 1.5 hour and Linux 1 hour. > Taking JDK 7 and 11, and one Maven version (3.5) is usually enough on Git > branches and should be fine for PRs as well. > > On Thu, Jan 3, 2019 at 10:19 PM Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > On Thu 3 Jan 2019 at 20:52, Tibor Digana <tibordig...@apache.org> wrote: > > > > > I already lost the point of this thread. > > > Still the disk space problem on Windows executors in ASF Jenkins? > > > If it's this issue, then why the workspace is not investigated directly > > on > > > the system with remote access? > > > Jenkins is very good tool and I do not want to use Travis but Travis is > > one > > > step after finding the root cause. > > > > > > We’re not going to be able to use Travis for Surefire (unless we have a > > “fast” suite of tests) > > > > That doesn’t mean we cannot use Travis for the 90 other repos we have in > > order to get test results of PRs from non-committers. > > > > > > > T > > > > > > On Thu, Jan 3, 2019 at 8:39 PM Stephen Connolly < > > > stephen.alan.conno...@gmail.com> wrote: > > > > > > > On Thu 3 Jan 2019 at 18:03, Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > > > > > Il gio 3 gen 2019, 17:38 Mickael Istria <mist...@redhat.com> ha > > > scritto: > > > > > > > > > > > Hi, > > > > > > > > > > > > I think this discussion is diverging into "trying TravisCI for > some > > > > > > plugins" and is loosing focus on the initial question of how to > > > improve > > > > > the > > > > > > build+test flow to get faster feedback as a contributor or as a > > > > reviewer. > > > > > > > > > > > > Travis will get the build+test flow faster for non-committers. > > > > > > > > > > > > > > Can the GitHub PR builder plugin be enabled on Maven Core ? > > > > > > > > > > > > No, it’s not compatible with how we build, as currently we only build > > > from > > > > gitbox not from GitHub so there is no link for Jenkins to see > > > > > > > > > > > > Committers > > > > > > would be allowed to trigger a test with a single comment once > they > > > > > checked > > > > > > it doesn't cause a security flaw. > > > > > > > > > > > > > > > > It turns out that it is not simple as it could seem because we have > > > > custom > > > > > Jenkins plugins to scan all the repos and have a common > > configuration, > > > so > > > > > in order to achieve such goal we need to enhance that plugin, > please > > > > > Stephen correct me if I am wrong. > > > > > > > > > > > > Yep I need to enhance the plugin a little... just trying to clear > stuff > > > off > > > > my plate > > > > > > > > > > > > > Travis jumped on this train because it is easy to enable and it is > > very > > > > > widespread, and it leaves security problems out of ASF infra. > > > > > But a check with Travis won't ever cover all jobs we are actually > > > > starting > > > > > per-branch. > > > > > It can be a good compromise to start, but if we have resources to > > > improve > > > > > current integration this will be the best choice for the mid term. > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > > -- > > > > > > > > > > > > > > > -- Enrico Olivelli > > > > > > > > > -- > > > > Sent from my phone > > > > > > > > > -- > > Sent from my phone > > > -- -- Enrico Olivelli
