Hi Starting again this thread as we agreed but I didn't do it. So I'd like to cut release 3.0.0-M4 by the end of this week.
On Mon, 14 Oct 2019 at 11:40, Tibor Digana <tibordig...@apache.org> wrote: > The SUREFIRE-1689 progress has been finished until the CI build succeeds. > T > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <rfscho...@apache.org> > wrote: > > > Ah, there it is :) > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau > > <rmannibu...@gmail.com> wrote: > > > > > Didnt expect my comment about shade to take so much space in this > thread > > > but yes we rely on asm for relocation: > > > > > > https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453 > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <rfscho...@apache.org> a > > > écrit : > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau > > >> <rmannibu...@gmail.com> wrote: > > >> > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rfscho...@apache.org> > a > > >> > écrit : > > >> > > > >> >> As far as I know, surefire won't touch the Plexus Java code that > > >> >> requires > > >> >> ASM. > > >> >> It is ONLY required when the runtime is Java 8 or lower AND you > > need > > >> to > > >> >> read the module descriptors. > > >> >> > > >> >> Maven Shade is a different case: it must parse the Java bytecode > (and > > >> >> only > > >> >> when using minifyJar), hence it needs the latest ASM. > > >> >> > > >> > > > >> > + Relocation ;) > > >> > > >> Well, the unexpected answer is actually No, see > > >> > > >> > > >> > > > https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java > > >> > > >> (but it might be better to do so...) > > >> > > >> > > > >> > > > >> >> Robert > > >> >> > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana > > >> >> <tibordig...@apache.org> > > >> >> > > >> >> wrote: > > >> >> > > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0. > > >> >> > The support for JDk 13 and 14 is in the version 7.2. > > >> >> > We have similar upgrade in > > >> >> > https://github.com/apache/maven-shade-plugin/pull/29 > > >> >> > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> > > >> wrote: > > >> >> > > > >> >> >> Hi, > > >> >> >> It's now almost 10 months since last and around 30 issues fixed. > > >> >> >> Maybe time for a new release? > > >> >> >> Moving issues still open to 3.0.0-M5? > > >> >> >> > > >> >> >> cheers > > >> >> >> -- > > >> >> >> Olivier Lamy > > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy > > >> >> > > >> >> > --------------------------------------------------------------------- > > >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> >> For additional commands, e-mail: dev-h...@maven.apache.org > > >> >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
