On 2011-07-30 00:13, Mark Struberg wrote: > Hi Dennis! > > I think we could test this if we start a local jetty serving as a repo http > server which only provides one dummy artifact. Then we need to startup a > proxy and point maven to this proxy. > > Sounds like a bit more work, and I'd rather do that in an integration test > and not via a unit test.
Yup, that's the way to go. I found the tests overly complicated for being just unit tests. > > LieGrue, > strub > > --- On Fri, 7/29/11, Dennis Lundberg <denn...@apache.org> wrote: > >> From: Dennis Lundberg <denn...@apache.org> >> Subject: Re: broken test in maven-javadoc-plugin >> To: "Maven Developers List" <dev@maven.apache.org> >> Date: Friday, July 29, 2011, 9:59 PM >> Hi Mark >> >> I spent a couple of hours debugging this earlier this >> week. >> Unfortunately I wasn't able to crack it. But I find your >> conclusion very >> plausible. >> >> On 2011-07-29 16:22, Mark Struberg wrote: >>> Hi! >>> >>> This is a sum-up of my last 5 hours of debugging. >>> >>> Currently there is a failing test in the >> maven-javadoc-plugin: JavadocReportTest#testProxy() >>> >>> This test fails since the last commit but I actually >> think it only ever worked by accident. It did rely on a >> commons-logging-1.0.4.pom which got resolved by a test which >> did run previously. >>> But after updating to commons-logging.1.1.1 there is >> no pre-resolved artifact available in target/local-repo >> anymore, thus the javadoc link info cannot get built and the >> test fails in line 829: >>>> assertTrue( optionsContent.contains( "-link >>>> 'http://commons.apache.org/logging/apidocs'" ) ); >>> >>> I'll for now just disable this line of code, because >> the test as far as I can see _never_ did go upstream. The >> remoteRepository list used is always empty!. >>> >>> If anyone has an idea how to get this fixed properly, >> then please speak up ;) >>> >>> LieGrue, >>> strug >>> >>> >>> >>> >>> >>> >> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> >> >> >> -- >> Dennis Lundberg >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Dennis Lundberg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
