>> This is why the project is open source. I don't think this patch is >> something I would generally promote if the end result is encouraging people >> to put binary dependencies in the source control system. But you are free to >> maintain a patched version, that's your right. >> > > I definitely second that. >
I am uncomfortable rejecting a patch that has no visible negative impact except that it it 'encourages people to put binary dependencies in SCM'. Maven users are presumably consenting adults. If adding this feature made something surprising, slow, or unhelpful happen to users doing the usual thing, I'd be -1 for it. But if it adds flexibility without conceptual or implementation overhead, I'd be +1. Another direction here is to ask what sort of pluggability would allow someone to inject this behavior without having to maintain a fork. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
