> -----Original Message----- > From: Mark Derricutt > Sent: Saturday, September 17, 2011 18:02 > To: Maven Developers List > Subject: Re: Request for review and comment > http://jira.codehaus.org/browse/MNG-5167 > > Would a compromise to something using the baseDir of the > project ( or root project ) and not an arbitrary relative path?
Currently, the patch supports LOCAL_REPOSITORY_RELATIVE_TO_VALUES.POM LOCAL_REPOSITORY_RELATIVE_TO_VALUES.M2_HOME LOCAL_REPOSITORY_RELATIVE_TO_VALUES.BASEDIRECTORY LOCAL_REPOSITORY_RELATIVE_TO_VALUES.WORKINGDIRECTORY LOCAL_REPOSITORY_RELATIVE_TO_VALUES.DEFAULT // As far as I have been able to test, DEFAULT and WORKINGDIRECTORY should and do behave the same, but the code for an explicit working directory is different that the current code. So the defaul uses an unchanged logic, and the working directory explicitly uses the CWD. I am working on adding support for LOCAL_REPOSITORY_RELATIVE_TO_VALUES.ROOT_PARENT_POM but this is also going to come when a few other issues in the configuration engin and reactor are fixed too. > > I can see a benefit to this, but I can also see not wanting > to allow the user to reach outside their SCM controlled project. > > > On 18/09/2011, at 3:42 AM, Benson Margulies wrote: > > > I am uncomfortable rejecting a patch that has no visible negative > > impact except that it it 'encourages people to put binary > dependencies > > in SCM'. Maven users are presumably consenting adults. If > adding this > > feature made something surprising, slow, or unhelpful > happen to users > > doing the usual thing, I'd be -1 for it. But if it adds flexibility > > without conceptual or implementation overhead, I'd be +1. > > -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- - - - Jason Pyeron PD Inc. http://www.pdinc.us - - Principal Consultant 10 West 24th Street #100 - - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 - - - -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- This message is copyright PD Inc, subject to license 20080407P00. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
