----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13006/#review24185 -----------------------------------------------------------
Ship it! src/webui/master/static/framework.html <https://reviews.apache.org/r/13006/#comment48010> I thought we were going to avoid having links from slave hostname -> executor page, just curious why you changed this back? src/webui/master/static/js/app.js <https://reviews.apache.org/r/13006/#comment48011> Great comment, thanks! src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/13006/#comment48013> For consistency, can you move the '.' to the same line as 'success'? .success(...) src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/13006/#comment48015> Maybe a TODO to improve the error handling here? There won't be a message indicating what went wrong? src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/13006/#comment48016> Interesting redirect technique, simply changing $location.path redirects? src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/13006/#comment48012> For consistency, can you move the '.' to the same line as 'error'? .error(...) src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/13006/#comment48017> Might be nice to show a relevant message to the user here as well. Sometimes users have network communication issues with the slaves (hidden behind a firewall) so any message as to why they can't click on the links successfully would help. TODO is ok for now! - Ben Mahler On July 28, 2013, 9:19 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13006/ > ----------------------------------------------------------- > > (Updated July 28, 2013, 9:19 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Link to executor sandbox from framework template > > The framework page is rendered with info from the master, but the > sandbox directory is known only by the slave. To link to the directory > from a page rendered by the master, create a page in between that acts > as a redirector by first asking for the directory from the slave. > > If the sandbox is important for linking, the master could return > `executor.directory` in the `state.json` endpoint and negate the need > for this redirection stuff. > > > Diffs > ----- > > src/webui/master/static/framework.html > 0cedb393455e6c858db69cf088b1a5cef7426f82 > src/webui/master/static/js/app.js d59e22c6f6debad757b415d5bf81cc34fcfee8e9 > src/webui/master/static/js/controllers.js > b9099e012e7893bb1213ab81f4d57160678bf75e > src/webui/master/static/slave_executor.html > 1e43aff172457e39a28e6a6fa13c03efc9f9f1fd > src/webui/master/static/slave_framework.html > 63eb5c4e85ad281ed6c348ac8cad9bc60534186b > > Diff: https://reviews.apache.org/r/13006/diff/ > > > Testing > ------- > > * Navigated to sandbox from framework page > * Visited redirect link with bad framework and bad executor ID to ensure it > redirected back properly > > > Thanks, > > Ross Allen > >
