> On July 30, 2013, 12:36 a.m., Ben Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 800-803 > > <https://reviews.apache.org/r/13006/diff/1/?file=330017#file330017line800> > > > > Interesting redirect technique, simply changing $location.path > > redirects? > > Ross Allen wrote: > "Redirect" is a misnomer here, and maybe the comment should be changed. > This navigates the browser to the URL, but there is no 301 or 302 response > code from the server telling the browser to redirect. > > This wraps `window.location`, which is provided by the browser: > https://developer.mozilla.org/en-US/docs/Web/API/window.location
Ah, would be good to update the comment to reflect this! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13006/#review24185 ----------------------------------------------------------- On July 30, 2013, 1:03 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13006/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 1:03 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Link to executor sandbox from framework template > > The framework page is rendered with info from the master, but the > sandbox directory is known only by the slave. To link to the directory > from a page rendered by the master, create a page in between that acts > as a redirector by first asking for the directory from the slave. > > If the sandbox is important for linking, the master could return > `executor.directory` in the `state.json` endpoint and negate the need > for this redirection stuff. > > > Diffs > ----- > > src/webui/master/static/framework.html > 0cedb393455e6c858db69cf088b1a5cef7426f82 > src/webui/master/static/js/app.js d59e22c6f6debad757b415d5bf81cc34fcfee8e9 > src/webui/master/static/js/controllers.js > c553e358e9f7598033e55a2e8dfff167d8282f7b > src/webui/master/static/slave_executor.html > 1e43aff172457e39a28e6a6fa13c03efc9f9f1fd > src/webui/master/static/slave_framework.html > 63eb5c4e85ad281ed6c348ac8cad9bc60534186b > > Diff: https://reviews.apache.org/r/13006/diff/ > > > Testing > ------- > > * Navigated to sandbox from framework page > * Visited redirect link with bad framework and bad executor ID to ensure it > redirected back properly > > > Thanks, > > Ross Allen > >
