> On July 30, 2013, 12:36 a.m., Ben Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 806-808 > > <https://reviews.apache.org/r/13006/diff/1/?file=330017#file330017line806> > > > > Might be nice to show a relevant message to the user here as well. > > Sometimes users have network communication issues with the slaves (hidden > > behind a firewall) so any message as to why they can't click on the links > > successfully would help. TODO is ok for now!
Good idea. I want to add a service similar to the Rails flash message[1] so a message can be set prior to the redirect and displayed on the next render. It's different from the current alert messages, which are based on the current state of the page. This one would be based on the state of the previous page. I will add a TODO about adding an alert service. [1] http://guides.rubyonrails.org/action_controller_overview.html#the-flash - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13006/#review24185 ----------------------------------------------------------- On July 30, 2013, 1:03 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13006/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 1:03 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Link to executor sandbox from framework template > > The framework page is rendered with info from the master, but the > sandbox directory is known only by the slave. To link to the directory > from a page rendered by the master, create a page in between that acts > as a redirector by first asking for the directory from the slave. > > If the sandbox is important for linking, the master could return > `executor.directory` in the `state.json` endpoint and negate the need > for this redirection stuff. > > > Diffs > ----- > > src/webui/master/static/framework.html > 0cedb393455e6c858db69cf088b1a5cef7426f82 > src/webui/master/static/js/app.js d59e22c6f6debad757b415d5bf81cc34fcfee8e9 > src/webui/master/static/js/controllers.js > c553e358e9f7598033e55a2e8dfff167d8282f7b > src/webui/master/static/slave_executor.html > 1e43aff172457e39a28e6a6fa13c03efc9f9f1fd > src/webui/master/static/slave_framework.html > 63eb5c4e85ad281ed6c348ac8cad9bc60534186b > > Diff: https://reviews.apache.org/r/13006/diff/ > > > Testing > ------- > > * Navigated to sandbox from framework page > * Visited redirect link with bad framework and bad executor ID to ensure it > redirected back properly > > > Thanks, > > Ross Allen > >
