----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13006/ -----------------------------------------------------------
(Updated Aug. 1, 2013, 4:24 a.m.) Review request for mesos and Benjamin Hindman. Changes ------- * Replace "redirect" with "navigate" and "reroute" in comments since "redirect" has a specific meaning in HTTP that doesn't apply here. * Revert task.id linking change to solve in another commit. * Add TODO for error messaging after rerouting. Repository: mesos-git Description (updated) ------- Link to executor sandbox from framework template The framework page is rendered with info from the master, but the sandbox directory is known only by the slave. To link to the directory from a page rendered by the master, create a page in between that acts as a redirector by first asking for the directory from the slave. If the sandbox is important for linking, the master could return `executor.directory` in the `state.json` endpoint and negate the need for this redirection stuff. Review: http://reviews.apache.org/r/13006 Diffs (updated) ----- src/webui/master/static/framework.html 0cedb393455e6c858db69cf088b1a5cef7426f82 src/webui/master/static/js/app.js d59e22c6f6debad757b415d5bf81cc34fcfee8e9 src/webui/master/static/js/controllers.js c553e358e9f7598033e55a2e8dfff167d8282f7b src/webui/master/static/slave_executor.html 1e43aff172457e39a28e6a6fa13c03efc9f9f1fd src/webui/master/static/slave_framework.html 63eb5c4e85ad281ed6c348ac8cad9bc60534186b Diff: https://reviews.apache.org/r/13006/diff/ Testing ------- * Navigated to sandbox from framework page * Visited redirect link with bad framework and bad executor ID to ensure it redirected back properly Thanks, Ross Allen
