----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14800/#review27419 -----------------------------------------------------------
Thanks for following through with this Yuval!! Can you confirm again that now all the combinations of --log_dir and --quiet work as expected? src/logging/logging.cpp <https://reviews.apache.org/r/14800/#comment53280> ... // Do not log to stderr instead of log files. FLAGS_logtostderr = false; } else { // Log to stderr instead of log files. FLAGS_logtostderr = true; } src/logging/logging.cpp <https://reviews.apache.org/r/14800/#comment53281> if (flags.quiet) { FLAGS_stderrthreshold = 3; // FATAL. // FLAGS_stderrthreshold is ignored when logging to stderr instead of log files. // Setting the minimum log level gets around this issue. if (FLAGS_logtostderr) { FLAGS_minloglevel = 3; // FATAL. } } else { FLAGS_stderrthreshold = 0; // INFO. } - Ben Mahler On Oct. 23, 2013, 8:03 p.m., Yuval Pavel Zholkover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14800/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 8:03 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The current intialization of glog creates log files in /tmp even when the > log_dir command argument is not passed. > Setting FLAGS_logtostderr to true disables all log file creation/writes. > > > Diffs > ----- > > src/logging/logging.cpp 850fb3c > > Diff: https://reviews.apache.org/r/14800/diff/ > > > Testing > ------- > > manual - during make check /tmp gets filled with glog logs (timestamped and > symlinked) > the patch fixes it > > > Thanks, > > Yuval Pavel Zholkover > >
