> On Oct. 23, 2013, 8:53 p.m., Ben Mahler wrote: > > Thanks for following through with this Yuval!! Can you confirm again that > > now all the combinations of --log_dir and --quiet work as expected? > > Yuval Pavel Zholkover wrote: > Yes I confirm that all 4 combinations of --log_dir and --quiet behave as > expected. Sorry for the multiple updates; revisions r5 is just a whitespace > cleanup, and r4 is a more concise version of r3. >
Perfect, can you do a final cleanup of the logic based on my comments below? Then we're all set! > On Oct. 23, 2013, 8:53 p.m., Ben Mahler wrote: > > src/logging/logging.cpp, line 100 > > <https://reviews.apache.org/r/14800/diff/5/?file=369963#file369963line100> > > > > ... > > // Do not log to stderr instead of log files. > > FLAGS_logtostderr = false; > > } else { > > // Log to stderr instead of log files. > > FLAGS_logtostderr = true; > > } - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14800/#review27419 ----------------------------------------------------------- On Oct. 23, 2013, 8:03 p.m., Yuval Pavel Zholkover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14800/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 8:03 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The current intialization of glog creates log files in /tmp even when the > log_dir command argument is not passed. > Setting FLAGS_logtostderr to true disables all log file creation/writes. > > > Diffs > ----- > > src/logging/logging.cpp 850fb3c > > Diff: https://reviews.apache.org/r/14800/diff/ > > > Testing > ------- > > manual - during make check /tmp gets filled with glog logs (timestamped and > symlinked) > the patch fixes it > > > Thanks, > > Yuval Pavel Zholkover > >
