> On Oct. 24, 2013, 8:24 p.m., Ben Mahler wrote: > > Great work Yuval!
This is now committed, please mark it as submitted! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14800/#review27483 ----------------------------------------------------------- On Oct. 23, 2013, 9:46 p.m., Yuval Pavel Zholkover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14800/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 9:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The current intialization of glog creates log files in /tmp even when the > log_dir command argument is not passed. > Setting FLAGS_logtostderr to true disables all log file creation/writes. > > > Diffs > ----- > > src/logging/logging.cpp 850fb3c > > Diff: https://reviews.apache.org/r/14800/diff/ > > > Testing > ------- > > manual - during make check /tmp gets filled with glog logs (timestamped and > symlinked) > the patch fixes it > > > Thanks, > > Yuval Pavel Zholkover > >
