----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15882/#review29504 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp <https://reviews.apache.org/r/15882/#comment56821> Will we still want this wrapper when we have c++11 and set has an initializer list constructor? 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp <https://reviews.apache.org/r/15882/#comment56819> After the call to set_union, we can just do: return std::set<T>(v.begin(), end); Instead of re-sizing and manually inserting into the result set, which is likely O(nlgn). 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp <https://reviews.apache.org/r/15882/#comment56820> Ditto, can just return std::set<T>(v.begin(), end); - Ben Mahler On Nov. 27, 2013, 7:26 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15882/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 7:26 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 47e8dbb1903179ecfd23ec550bfe79fd54322528 > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/15882/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
