> On Nov. 27, 2013, 8:43 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp, lines 4-35 > > <https://reviews.apache.org/r/15882/diff/1/?file=391815#file391815line4> > > > > Will we still want this wrapper when we have c++11 and set has an > > initializer list constructor?
Maybe? I could see us wanting some other methods on Set that std::set doesn't have. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15882/#review29504 ----------------------------------------------------------- On Nov. 27, 2013, 8:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15882/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 8:45 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 47e8dbb1903179ecfd23ec550bfe79fd54322528 > 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp > 78bed739e62134a858fd3c57b1842decd2240074 > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/15882/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
