----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15882/#review29507 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp <https://reviews.apache.org/r/15882/#comment56823> Thanks! In this case, it's because we'd have to copy into vectors and sort our hashsets, which we don't have to do with plain ordered set. 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp <https://reviews.apache.org/r/15882/#comment56824> Given the cleanup in the & operator, I don't think set_union is more complicated (in the previous diff it certainly was but now & is quite simple as well! :)). So feel free to use set_union here too now that it's been simplified! - Ben Mahler On Nov. 27, 2013, 8:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15882/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 8:45 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 47e8dbb1903179ecfd23ec550bfe79fd54322528 > 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp > 78bed739e62134a858fd3c57b1842decd2240074 > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/15882/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
