Thanks Niklas. I used 'std::set<T>::insert' instead of 'this->' to be more explicit. Let me know if something still doesn't work for you, thanks!
On Mon, Dec 2, 2013 at 9:59 AM, Niklas Nielsen <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15882/ > > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp<https://reviews.apache.org/r/15882/diff/2/?file=391865#file391865line12> > (Diff > revision 2) > > 12 > > insert(t1); > > Hey! > > I get build errors here with GCC 4.8.1: https://gist.github.com/nqn/7753492 > > Explicit "this->" in front of insert() fixed it: > https://gist.github.com/nqn/7753449 > > I might of course just be equipped with a over-pedantic compiler :) > > Cheers! > > > - Niklas Nielsen > > On November 27th, 2013, 8:45 p.m. UTC, Benjamin Hindman wrote: > Review request for mesos, Ben Mahler and Jie Yu. > By Benjamin Hindman. > > *Updated Nov. 27, 2013, 8:45 p.m.* > *Repository: * mesos-git > Description > > See summary. > > Testing > > make check > > Diffs > > - 3rdparty/libprocess/3rdparty/stout/Makefile.am > (47e8dbb1903179ecfd23ec550bfe79fd54322528) > - 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp > (78bed739e62134a858fd3c57b1842decd2240074) > - 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp > (PRE-CREATION) > - 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/15882/diff/> >
