----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review31536 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/15542/#comment60065> I was wrong about marking this as deprecated, it still seems useful for frameworks that want the shell to search for binaries on the PATH. Can you kill the comment here? src/launcher/executor.cpp <https://reviews.apache.org/r/15542/#comment60054> Where is commandMessage used? Consider: string commandMessage = "command: " + strings::join(" ", args) + "\n"; src/launcher/executor.cpp <https://reviews.apache.org/r/15542/#comment60055> Does this compile? Should this be commandMessage? src/launcher/executor.cpp <https://reviews.apache.org/r/15542/#comment60057> Since commandVector does not store a vector, what about calling this _argv (since it's really just storing argv in another form for execvp to stomach). Why does this call to execvp need an intermediate variable, whereas the one in launcher does not? src/launcher/launcher.cpp <https://reviews.apache.org/r/15542/#comment60059> Does this need a newline? Consider: string message = "Could not execute: " + strings::join(" ", args) + "\n"; src/slave/process_isolator.cpp <https://reviews.apache.org/r/15542/#comment60063> Ditto, why does this one need the intermediate commandVector, but the one in launcher does not? - Ben Mahler On Dec. 31, 2013, 11:54 p.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2013, 11:54 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp 0bc698f04f7c8eaad166dc9d646e13310129dd01 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
