> On Jan. 18, 2014, 1:32 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 134-137 > > <https://reviews.apache.org/r/15542/diff/11/?file=426622#file426622line134> > > > > s/bytes/string on these two > > > > The resulting 'executor.command.command.command' is a bit unfortunate, > > do you foresee other fields in Command? > > > > If not, let's just directly embed it in CommandInfo: > > > > message CommandInfo { > > // Setting value is equivalent to: > > // command = 'sh' > > // arguments = ['-c', value] > > // > > // Deprecated, please use 'command' and 'arguments' instead. > > required string value = 3; > > > > optional string command = 4; > > repeated string arguments = 5; > > } > > > > It seems that this makes the API a bit cleaner to use, how does this > > sound?
I will make the switch from 'bytes' to 'string' as you have suggested. I have some doubts about it -- my intuition suggests this will create vexing limitations sometimes -- but many of my fears are allayed by the fact that Protobuf specifies strings as UTF-8. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review32234 ----------------------------------------------------------- On Jan. 21, 2014, 6:50 a.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 6:50 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp 0bc698f04f7c8eaad166dc9d646e13310129dd01 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
