> On Jan. 18, 2014, 1:32 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, line 141 > > <https://reviews.apache.org/r/15542/diff/11/?file=426622#file426622line141> > > > > We should try to move this to an optional field to make the semantics > > more clear to frameworks, but we'll need to go through a few release cycles > > to do this. > > > > We would have compatibility issues if we were to move this to optional > > immediately, since messages originating from an upgraded framework will not > > be parseable my the Master / Slave. > > > > 1. As a first step, let's modify sched.cpp to set 'value' to an empty > > string when 'command' is set. This will ensure that when upgrading to a > > subsequent release, all messages coming from the scheduler driver will have > > the field set. > > > > 2. Subsequently, and let's leave TODOs for this, we'll be able to move > > this safely to an optional field. > > > > Removing it entirely would be a bit trickier, since it's a breaking API > > change, I would recommend linking a ticket into MESOS-810 to capture this > > dependency. Sound good?
This seems like a good approach. Please expect results in a day or two. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review32234 ----------------------------------------------------------- On Jan. 21, 2014, 6:50 a.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 6:50 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp 0bc698f04f7c8eaad166dc9d646e13310129dd01 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
