----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review34249 -----------------------------------------------------------
src/examples/python/test_containerizer.py <https://reviews.apache.org/r/17567/#comment64286> Should this be hard coded? Seems to me like this will fail if i'm running mesos from the build directory without installing. src/slave/containerizer/pluggable_containerizer.hpp <https://reviews.apache.org/r/17567/#comment64287> This seems a little odd to me... surely a 0 exit code should suggest a successful invoke no matter what the external containerizer writes to stdout? src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment64288> Hmm. If the container hasn't launched and we disregard the update request, does this mean we're going to completely ignore a change to resources? Would it not make sense to pass the update request on to the external containerizer anyway and give them the opportunity to make this decision? The external containerizer might want to make note of "pending" resource changes and apply them once the container is up (or wait for the container to come up). src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment64289> Might be nice to have a more detailed log message, if I see this in logs it doesn't tell me which containerID it's referencing. src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment64290> Does this method assume killing the external containerizer process will successfully kill the container? In the case of docker, if you kill the `docker run` call it will certainly kill cleanly, but the container is still running. You need to execute a `docker kill XXX` command to cleanly kill the running container (which will exit non-0 if it fails). - Tom Arnfeld On Feb. 11, 2014, 5:39 a.m., TILL TOENSHOFF wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 5:39 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called pluggable containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). Few calls have internal fall-back implementations > such as wait(), destroy() and usage(). > The protocol for the interactions with the external program > is as follows: > ./containerizer <command> <container-id> (<optional parameters>) > When protocol buffers need to be provided, the Mesos side of > the pluggable containerizer will serialize the protos on stdin > and vice-versa for reading protos on stdout. > > > NOTE: Still work in progress and not yet reviewable. > > > Diffs > ----- > > configure.ac f69908af84882088ccbf14f89cf46c3a5364cabf > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.hpp PRE-CREATION > src/slave/containerizer/containerizer.cpp PRE-CREATION > src/slave/containerizer/mesos_containerizer.hpp PRE-CREATION > src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION > src/slave/flags.hpp 827b2d0d6dc8fa279f3187a09e5dc6d4799d17cd > src/slave/slave.hpp b00f97057fd2f9ba72364cb41c543bd24a97b0fa > src/slave/slave.cpp 396293b1749afcbebdf366f4105b46e8ec7749de > src/slave/status_update_manager.cpp > f7a0c40f1b1a8cfab828998146b8f446a0569251 > src/tests/containerizer.hpp PRE-CREATION > src/tests/containerizer.cpp PRE-CREATION > src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1 > src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364 > src/tests/pluggable_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > > Thanks, > > TILL TOENSHOFF > >
