> On Feb. 18, 2014, 5:32 p.m., Dominic Hamon wrote: > > src/slave/containerizer/pluggable_containerizer.cpp, line 68 > > <https://reviews.apache.org/r/17567/diff/6/?file=496485#file496485line68> > > > > you have a 'using std::string' so you don't need the std:: prefices > > throughout.
Oops, that slipped in. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review34710 ----------------------------------------------------------- On Feb. 28, 2014, 1:23 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 1:23 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes, > Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called pluggable containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). Few calls have internal fall-back implementations > such as wait(), destroy() and usage(). > > The protocol for the interactions with the external program > is as follows: > > COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO > > launch (ContainerID, --mesos-executor, <path>) < TaskInfo > PluggableStatus > update (ContainerID) < ResourceArray > PluggableStatus > usage (ContainerID) > ResourceStatistics > wait (ContainerID) > PluggableTermination > destroy (ContainerID) > PluggableStatus > > When protocol buffers need to be provided, the Mesos side of > the pluggable containerizer will serialize the protos on stdin > and vice-versa for reading protos on stdout as drafted in the > above scheme. > > > Diffs > ----- > > configure.ac a8bc8a8 > include/mesos/mesos.proto 37f8a7f > src/Makefile.am 61d832b > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.cpp d0a1023 > src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION > src/slave/flags.hpp e4d98a5 > src/tests/pluggable_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > >
