----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review34710 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/17567/#comment64922> watch the tab here src/slave/containerizer/containerizer.cpp <https://reviews.apache.org/r/17567/#comment64923> given the 'if' is returning, you don't need an else. You can also then unindent the rest of the code below. src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment64924> you have a 'using std::string' so you don't need the std:: prefices throughout. src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment64926> a side note for others to consider - do you think it's worth using ResourceArray instead of Resources everywhere? The overhead of the protobuf might be a cost that we don't want to pay, but having two ways of representing a list of Resource objects could be confusing. - Dominic Hamon On Feb. 18, 2014, 8:30 a.m., TILL TOENSHOFF wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 8:30 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called pluggable containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). Few calls have internal fall-back implementations > such as wait(), destroy() and usage(). > The protocol for the interactions with the external program > is as follows: > ./containerizer <command> <container-id> (<optional parameters>) > When protocol buffers need to be provided, the Mesos side of > the pluggable containerizer will serialize the protos on stdin > and vice-versa for reading protos on stdout. > > > NOTE: Still work in progress and not yet reviewable. > > > Diffs > ----- > > configure.ac a8bc8a8 > include/mesos/mesos.proto 69a4a60 > src/Makefile.am 768c66a > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.hpp d9ae326 > src/slave/containerizer/containerizer.cpp d0a1023 > src/slave/containerizer/mesos_containerizer.hpp ee1fd30 > src/slave/containerizer/mesos_containerizer.cpp 6d990cb > src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION > src/slave/flags.hpp e4d98a5 > src/slave/slave.hpp d82d4e9 > src/slave/slave.cpp 8ad955a > src/slave/status_update_manager.cpp a88bb18 > src/tests/containerizer.hpp 5686398 > src/tests/containerizer.cpp bfb9341 > src/tests/mesos.cpp 98333a7 > src/tests/pluggable_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > > Thanks, > > TILL TOENSHOFF > >
