----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19093/#review37158 -----------------------------------------------------------
Looks good. Just a few style nits, a rename, and a suggested log message rewording. 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp <https://reviews.apache.org/r/19093/#comment68561> s/getuid/setgid/ for "set-group-ID on execution" 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp <https://reviews.apache.org/r/19093/#comment68560> indentation 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp <https://reviews.apache.org/r/19093/#comment68562> setgid 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp <https://reviews.apache.org/r/19093/#comment68564> Double-space please src/master/master.cpp <https://reviews.apache.org/r/19093/#comment68565> Line up with the '<<' on the line above src/master/master.cpp <https://reviews.apache.org/r/19093/#comment68566> - Please remove the '!' at the end of this warning message. Exclamations points are rarely needed in log messages, especially when the severity is already expressed by the log level. We usually don't even put periods at the end of log messages. - The word 'insufficient' insufficiently explains what's wrong with the permissions on the file. Explain that the credentials file is globally readable/writable, and recommend a new setting (e.g. 'chmod o-rwx' or 'rw-r-----' or '640'). - Adam B On March 13, 2014, 1:47 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19093/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:47 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1087 > https://issues.apache.org/jira/browse/MESOS-1087 > > > Repository: mesos-git > > > Description > ------- > > Adding permissions check on credentials file and deleting TODO comment > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 1075b46 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 3f475a4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp > PRE-CREATION > src/master/master.cpp 2a40333 > > Diff: https://reviews.apache.org/r/19093/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
