> On March 14, 2014, 5:46 a.m., Adam B wrote: > > src/master/master.cpp, lines 299-300 > > <https://reviews.apache.org/r/19093/diff/3/?file=518207#file518207line299> > > > > - Please remove the '!' at the end of this warning message. > > Exclamations points are rarely needed in log messages, especially when the > > severity is already expressed by the log level. We usually don't even put > > periods at the end of log messages. > > - The word 'insufficient' insufficiently explains what's wrong with the > > permissions on the file. Explain that the credentials file is globally > > readable/writable, and recommend a new setting (e.g. 'chmod o-rwx' or > > 'rw-r-----' or '640'). > > Benjamin Hindman wrote: > Isabel was just copying my suggestion for a log message (which included > the exclamation point) and she had already pointed out that 'insufficient' > was insufficient. ;) I think explaining the problem is great but I don't > think it's necessary to tell people how to fix it.
I changed the log message to a modified copy of the same case 'ssh' log message. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19093/#review37158 ----------------------------------------------------------- On March 14, 2014, 8:08 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19093/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 8:08 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1087 > https://issues.apache.org/jira/browse/MESOS-1087 > > > Repository: mesos-git > > > Description > ------- > > Adding permissions check on credentials file and deleting TODO comment > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 1075b46 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 3f475a4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp > PRE-CREATION > src/master/master.cpp 2a40333 > > Diff: https://reviews.apache.org/r/19093/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
