> On March 21, 2014, 11:59 p.m., Ben Mahler wrote: > > Looks like we forgot to split apart this change between stout and Mesos. We > > typically break apart commits to libprocess, stout as they are libraries > > that are also maintained on github. > > > > There were also some hard tabs here, where we normally use spaces, but I > > fixed these for you so don't worry about cleaning them up! > >
Thank you, I commented in JIRA about seeing that the librarie was on GitHub but it seemed inactive on its repository, and still active directly on Mesos repository. Sorry about that. Also didn't see hard tabs on my IDE config I will update it for next time. Thank you again for pointing it out. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19093/#review38236 ----------------------------------------------------------- On March 14, 2014, 8:08 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19093/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 8:08 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1087 > https://issues.apache.org/jira/browse/MESOS-1087 > > > Repository: mesos-git > > > Description > ------- > > Adding permissions check on credentials file and deleting TODO comment > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 1075b46 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 3f475a4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp > PRE-CREATION > src/master/master.cpp 2a40333 > > Diff: https://reviews.apache.org/r/19093/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
