----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review38265 -----------------------------------------------------------
Patch looks great! Reviews applied: [18957] All tests passed. - Mesos ReviewBot On March 23, 2014, 11:18 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 11:18 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > For this specific flag, the configuration phase will attempt to locate a > preinstalled dependency. If that was not found, we show a warning and fall > back to using the bundled version. > If --disable-bundled is supplied or --with-leveldb=DIR was given but the > configuration phase could not locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb=DIR was given, the > bundled library is built and used. > > NOTE: This review only implements this preinstalled library usage on LevelDB. > For using the preinstalled LevelDB from a location that is not part of the > standard include and linker paths, you may specify > --with-leveldb=PREFIX_PATH. Subsequent review requests for other bundled > libraries will follow as soon as this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 5404dc2 > src/Makefile.am 0775a0d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --disable-bundled > make check > > > Thanks, > > Till Toenshoff > >
