> On March 20, 2014, 9:46 a.m., Benjamin Hindman wrote: > > Just so I understand clearly, do we not want to allow people to try and use > > system installed libraries but fall back on what's bundled otherwise? > > Consider someone who has leveldb installed with snappy, so they'd like to > > use the system installed leveldb but use everything else that is bundled so > > they don't have to go install all those things, can they do that? > > > > Also, I agree with Adam that --enable-proper isn't as descriptive as say, > > --with-installed-dependencies. > > Timothy St. Clair wrote: > The point that Vinod made on the ticket was: "I would prefer to also have > an option to always use bundled dependencies irrespective of system installed > ones. In fact this could be the default so as to not break users that are > already expect this behavior. After a deprecation period we could change the > default to prefer system installed dependencies." That is how the patch was > setup. > > I personally like --disable-bundled, but I don't have strong opinions on > the matter. > > Till Toenshoff wrote: > "--disable-bundled" sounds great to me.
Naming rant: I think we've agreed that 'Proper' isn't descriptive enough. Here are my thoughts on alternatives. * Bundled: disable-bundled or without-bundled implies no fallback to bundled. Since the fallback /is/ to use the bundled libs, the enable/disable or with/without naming should really apply to the unbundled, preinstalled, external, system dependencies. * [Pre]installed: If I'm passing a path, the dependency isn't necessarily "installed" somewhere. "Installed" also has too many other potential meanings (e.g. to-be-installed by mesos). * External: Could be too generic if there are other external dependencies that are not covered by these --with-foo flags. * System: With the new logic, this parameter only applies to dependencies that already exist on the lib-path, and is ignored for libs that pass an explicit --with-foo=path, so "system" may be more appropriate that "external". * Dependencies vs. Libraries: Since installed/external/system is too vague by itself, it needs an object to describe. I prefer "dependencies" over "libraries", since it's a little more general and can express dependencies that are more than just libraries. TL;DR: I vote for: --with[out]-system-dependencies. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review37907 ----------------------------------------------------------- On March 23, 2014, 4:18 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 4:18 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > For this specific flag, the configuration phase will attempt to locate a > preinstalled dependency. If that was not found, we show a warning and fall > back to using the bundled version. > If --disable-bundled is supplied or --with-leveldb=DIR was given but the > configuration phase could not locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb=DIR was given, the > bundled library is built and used. > > NOTE: This review only implements this preinstalled library usage on LevelDB. > For using the preinstalled LevelDB from a location that is not part of the > standard include and linker paths, you may specify > --with-leveldb=PREFIX_PATH. Subsequent review requests for other bundled > libraries will follow as soon as this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 5404dc2 > src/Makefile.am 0775a0d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --disable-bundled > make check > > > Thanks, > > Till Toenshoff > >
