-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19176/
-----------------------------------------------------------
(Updated March 28, 2014, 2:59 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Simplified my overzealous changelist down to the core requirement of removing
FrameworkID from the Master::Framework and Slave::Framework constructors,
pulling the id from the FrameworkInfo.
Also ensured that the FrameworkInfo always has the FrameworkID set by the time
we construct a Framework out of it. In Slave::runTask, we must merge the
FrameworkID into the FrameworkInfo, in case we're receiving a message from an
older master; and in Slave::recoverFramework we must merge in case the
checkpointed state is older.
The following (removed) changes can be handled in subsequent reviews:
- Remove the redundant FrameworkID from
allocator->frameworkAdded/frameworkActivated calls.
- Fix unnecessary extra looping in reregisterFramework to add the framework's
tasks from each activated slave.
- Move newFramework/Id() into private scope.
- (Cannot deprecate required FrameworkID fields in
RunTaskMessage/ExecutorRegisteredMessage, because required is forever.)
- Various style changes can be batched in lint cleanup reviews.
Bugs: MESOS-905
https://issues.apache.org/jira/browse/MESOS-905
Repository: mesos-git
Description
-------
Eliminated the Framework.id FrameworkID field in master and slave, and replaced
each with a Framework.id() accessor that references Framework.FrameworkInfo.id.
Removed redundant FrameworkID parameters when FrameworkInfo parameters also
exist with valid contained FrameworkID.
Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer need
the FrameworkID member, but it is 'required' and cannot be easily deprecated.
Due to rolling upgrades, we must (a) continue to set the FrameworkID in the
messages, in case the recipient is on an older version that needs it; and (b)
merge the FrameworkID into the FrameworkInfo.id, in case we are receiving a
message from an older sender.
Diffs (updated)
-----
src/master/master.hpp 0c7c520
src/master/master.cpp 6da7766
src/slave/slave.hpp 01b80df
src/slave/slave.cpp d8d3e0f
Diff: https://reviews.apache.org/r/19176/diff/
Testing
-------
make check on ubuntu(Mint14)/gcc4.7.2.
Thanks,
Adam B
