----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19176/#review38961 -----------------------------------------------------------
Patch looks great! Reviews applied: [19176] All tests passed. - Mesos ReviewBot On March 28, 2014, 9:59 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19176/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 9:59 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-905 > https://issues.apache.org/jira/browse/MESOS-905 > > > Repository: mesos-git > > > Description > ------- > > Eliminated the Framework.id FrameworkID field in master and slave, and > replaced each with a Framework.id() accessor that references > Framework.FrameworkInfo.id. > Removed redundant FrameworkID parameters when FrameworkInfo parameters also > exist with valid contained FrameworkID. > Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer need > the FrameworkID member, but it is 'required' and cannot be easily deprecated. > Due to rolling upgrades, we must (a) continue to set the FrameworkID in the > messages, in case the recipient is on an older version that needs it; and (b) > merge the FrameworkID into the FrameworkInfo.id, in case we are receiving a > message from an older sender. > > > Diffs > ----- > > src/master/master.hpp 0c7c520 > src/master/master.cpp 6da7766 > src/slave/slave.hpp 01b80df > src/slave/slave.cpp d8d3e0f > > Diff: https://reviews.apache.org/r/19176/diff/ > > > Testing > ------- > > make check on ubuntu(Mint14)/gcc4.7.2. > > > Thanks, > > Adam B > >
