I will take a look, thanks Adam!
On Wed, Apr 23, 2014 at 6:55 PM, Adam B <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19176/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 6:55 p.m.) > > > Review request for mesos and Ben Mahler. > > > Changes > ------- > > Rebased. Please review. > > > Bugs: MESOS-905 > https://issues.apache.org/jira/browse/MESOS-905 > > > Repository: mesos-git > > > Description > ------- > > Eliminated the Framework.id FrameworkID field in master and slave, and > replaced each with a Framework.id() accessor that references > Framework.FrameworkInfo.id. > Removed redundant FrameworkID parameters when FrameworkInfo parameters > also exist with valid contained FrameworkID. > Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer > need the FrameworkID member, but it is 'required' and cannot be easily > deprecated. Due to rolling upgrades, we must (a) continue to set the > FrameworkID in the messages, in case the recipient is on an older version > that needs it; and (b) merge the FrameworkID into the FrameworkInfo.id, in > case we are receiving a message from an older sender. > > > Diffs (updated) > ----- > > src/master/master.hpp f567a43 > src/master/master.cpp 0335b34 > src/slave/slave.hpp 438e5b5 > src/slave/slave.cpp b673fd6 > > Diff: https://reviews.apache.org/r/19176/diff/ > > > Testing > ------- > > make check on ubuntu(Mint14)/gcc4.7.2. > > > Thanks, > > Adam B > >
