----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19176/#review41499 -----------------------------------------------------------
Hey Adam, it looks like you're trying to also not rely on FrameworkID in RunTaskMessage? If so, are you planning to remove it? I would say let's assume it is set for now, because this requires 3 phases anyway: 1. Version N: Move 'required' to 'optional', keep setting it. 2. Version N+1: Keep as 'optional', keep setting it. Handle it being unset. 3. Version N+2: (Now N-1 has 'optional' and can handle unset), remove the field. Since we're currently aiming at Version N, let's keep assuming it is set when the slave receives the message. src/master/master.cpp <https://reviews.apache.org/r/19176/#comment74943> Do you need this utils::copy()? FrameworkInfo frameworkInfo_ = frameworkInfo; Looks like the copy constructor would be used either way, anything I'm missing here? src/slave/slave.cpp <https://reviews.apache.org/r/19176/#comment74948> This is pretty concerning! :( Please follow up on MESOS-906. src/slave/slave.cpp <https://reviews.apache.org/r/19176/#comment74955> Are you looking to remove the redundant FrameworkID from the RunTaskMessage? If so, please leave a TODO in messages.proto. Let's try to make it clear in the code that we were doing a deprecation! How are you planning to do this since frameworkId is required? Otherwise, no need to avoid using the passed in 'frameworkId'. src/slave/slave.cpp <https://reviews.apache.org/r/19176/#comment74949> utils::copy not needed? src/slave/slave.cpp <https://reviews.apache.org/r/19176/#comment74956> This seems unnecessary given the if condition? src/slave/slave.cpp <https://reviews.apache.org/r/19176/#comment74958> No need for utils::copy? src/slave/slave.cpp <https://reviews.apache.org/r/19176/#comment74957> Please remove this one as well. - Ben Mahler On April 24, 2014, 1:55 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19176/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 1:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-905 > https://issues.apache.org/jira/browse/MESOS-905 > > > Repository: mesos-git > > > Description > ------- > > Eliminated the Framework.id FrameworkID field in master and slave, and > replaced each with a Framework.id() accessor that references > Framework.FrameworkInfo.id. > Removed redundant FrameworkID parameters when FrameworkInfo parameters also > exist with valid contained FrameworkID. > Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer need > the FrameworkID member, but it is 'required' and cannot be easily deprecated. > Due to rolling upgrades, we must (a) continue to set the FrameworkID in the > messages, in case the recipient is on an older version that needs it; and (b) > merge the FrameworkID into the FrameworkInfo.id, in case we are receiving a > message from an older sender. > > > Diffs > ----- > > src/master/master.hpp f567a43 > src/master/master.cpp 0335b34 > src/slave/slave.hpp 438e5b5 > src/slave/slave.cpp b673fd6 > > Diff: https://reviews.apache.org/r/19176/diff/ > > > Testing > ------- > > make check on ubuntu(Mint14)/gcc4.7.2. > > > Thanks, > > Adam B > >
