----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/#review39477 -----------------------------------------------------------
Ship it! Looks good. Have you seen https://github.com/google/benchmark </shamelessplug>? Makefile.am <https://reviews.apache.org/r/20017/#comment71878> s/prerequisits/prerequisites/ - Dominic Hamon On April 3, 2014, 2:23 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20017/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 2:23 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1190 > https://issues.apache.org/jira/browse/MESOS-1190 > > > Repository: mesos-git > > > Description > ------- > > - The 'benchmark' tests are the GTEST test cases or tests with the name > containing 'BENCHMARK_'. > - The tests can be inovked by 'make bench' command or 'make check' with a > non-zero environment variable MESOS_RUN_BENCHMARKS value. > > > Diffs > ----- > > Makefile.am bb96565 > src/tests/environment.cpp feeca04 > > Diff: https://reviews.apache.org/r/20017/diff/ > > > Testing > ------- > > - make check > - make bench, which is equivalent of MESOS_RUN_BENCHMARKS=1 make check > - make bench with GTESTS filters > > > Thanks, > > Jiang Yan Xu > >
