----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/#review39823 -----------------------------------------------------------
Makefile.am <https://reviews.apache.org/r/20017/#comment72487> Does this sentence make sense? Makefile.am <https://reviews.apache.org/r/20017/#comment72488> By building the entire 'system' do you mean to say that it includes the test dependencies, or? I didn't understand from the comment why this was placed in the top-level makefile, is this not because we have an explicit 'bench' target? Meaning, to have 'make bench' work in the build directory, we have to place it in the top level makefile? Can you clarify this comment? src/tests/environment.cpp <https://reviews.apache.org/r/20017/#comment72486> Why is this after the loop on 'names'? Please add a comment if it's necessary to be done outside the loop. src/tests/flags.hpp <https://reviews.apache.org/r/20017/#comment72485> I would read this as a verb so 'benchmark' sounds more accurate. If plural, we would probably want to make it 'enable_benchmarks'. How about s/benchmarks/benchmark/ ? - Ben Mahler On April 8, 2014, 9:49 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20017/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 9:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1190 > https://issues.apache.org/jira/browse/MESOS-1190 > > > Repository: mesos-git > > > Description > ------- > > - The 'benchmark' tests are the GTEST test fixtures or tests with the name > containing 'BENCHMARK_'. > - The tests can be invoked by 'make bench' command or 'MESOS_BENCHMARKS=1 > make check'. > - These tests can also be run by <build>/bin/mesos-tests.sh --benchmarks > > > Diffs > ----- > > Makefile.am bb96565a48f2fb70f38bf033945a63cb4c8b407c > src/tests/environment.hpp 02a897b07a04c5111e40d6ce3ad653a49cb9919b > src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90 > src/tests/flags.hpp 9760a7a1b074a759d0bd0e6d799f45f6a2dacc7e > src/tests/main.cpp ba9bf64babf037ac66a4ab7ae8f473bcb61ac0fd > > Diff: https://reviews.apache.org/r/20017/diff/ > > > Testing > ------- > > - make check > - make bench, which is equivalent of MESOS_BENCHMARKS=1 make check > - make bench with GTESTS filters > - <build>/bin/mesos-tests.sh --benchmarks, <build>/bin/mesos-tests.sh > --no-benchmarks, <build>/bin/mesos-tests.sh --help (checked output). > > > Thanks, > > Jiang Yan Xu > >
