-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20017/
-----------------------------------------------------------

(Updated April 8, 2014, 2:49 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

BenM's comments (offline):

Added a TODO and leveraged the Mesos Flags to support this feature.


Bugs: MESOS-1190
    https://issues.apache.org/jira/browse/MESOS-1190


Repository: mesos-git


Description (updated)
-------

- The 'benchmark' tests are the GTEST test fixtures or tests with the name 
containing 'BENCHMARK_'.
- The tests can be invoked by 'make bench' command or 'MESOS_BENCHMARKS=1 make 
check'.
- These tests can also be run by <build>/bin/mesos-tests.sh --benchmarks


Diffs (updated)
-----

  Makefile.am bb96565a48f2fb70f38bf033945a63cb4c8b407c 
  src/tests/environment.hpp 02a897b07a04c5111e40d6ce3ad653a49cb9919b 
  src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90 
  src/tests/flags.hpp 9760a7a1b074a759d0bd0e6d799f45f6a2dacc7e 
  src/tests/main.cpp ba9bf64babf037ac66a4ab7ae8f473bcb61ac0fd 

Diff: https://reviews.apache.org/r/20017/diff/


Testing (updated)
-------

- make check
- make bench, which is equivalent of MESOS_BENCHMARKS=1 make check
- make bench with GTESTS filters
- <build>/bin/mesos-tests.sh --benchmarks, <build>/bin/mesos-tests.sh 
--no-benchmarks, <build>/bin/mesos-tests.sh --help (checked output).


Thanks,

Jiang Yan Xu

Reply via email to