> On April 3, 2014, 2:39 p.m., Dominic Hamon wrote: > > Looks good. > > > > Have you seen https://github.com/google/benchmark </shamelessplug>?
Looks interesting! We should integrate it into our testing tools. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/#review39477 ----------------------------------------------------------- On April 4, 2014, 11:20 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20017/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 11:20 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1190 > https://issues.apache.org/jira/browse/MESOS-1190 > > > Repository: mesos-git > > > Description > ------- > > - The 'benchmark' tests are the GTEST test cases or tests with the name > containing 'BENCHMARK_'. > - The tests can be inovked by 'make bench' command or 'make check' with a > non-zero environment variable MESOS_RUN_BENCHMARKS value. > > > Diffs > ----- > > Makefile.am bb96565a48f2fb70f38bf033945a63cb4c8b407c > src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90 > > Diff: https://reviews.apache.org/r/20017/diff/ > > > Testing > ------- > > - make check > - make bench, which is equivalent of MESOS_RUN_BENCHMARKS=1 make check > - make bench with GTESTS filters > > > Thanks, > > Jiang Yan Xu > >
