----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20502/#review40953 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/20502/#comment74274> s/backoffInterval/duration/ to be consistent with how we named it in status update manager. src/slave/slave.cpp <https://reviews.apache.org/r/20502/#comment74287> Instead of doing this way, can we just add the jitter the first time doReliableRegistration() is called (e.g., in in detected()) That way the code here could be simplified (similar to what we did in status update manager) and easy to reason about? src/slave/slave.cpp <https://reviews.apache.org/r/20502/#comment74282> Why 16 seconds? Seems too low of a value? How about 10 min like we did for status updates? Either way pull this out to a constant (e.g., SLAVE_RETRY_INTERVAL_MAX). - Vinod Kone On April 20, 2014, 9:49 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20502/ > ----------------------------------------------------------- > > (Updated April 20, 2014, 9:49 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-982 > https://issues.apache.org/jira/browse/MESOS-982 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 1e9879582315fabb76659e9f8eb03f90188fbfa0 > src/slave/slave.cpp d6ec87c2232c2172f471ae30711b5da1c7050570 > > Diff: https://reviews.apache.org/r/20502/diff/ > > > Testing > ------- > > make check. Also tested the random backoff logic separately. > > > Thanks, > > Jiang Yan Xu > >
