> On April 22, 2014, 11:31 a.m., Ben Mahler wrote: > > src/slave/constants.cpp, line 33 > > <https://reviews.apache.org/r/20502/diff/2/?file=564235#file564235line33> > > > > A flag for this would be nice! > > > > Are you planning to expose the minimum as well? 1 second might be a > > small minimum for large clusters (10,000+ slaves).
Ok the flag will make https://reviews.apache.org/r/20561/ unnecessary (for now). I think what should be configurable through flags is not this but the slaves.recoveredTimer: https://github.com/apache/mesos/blob/12e1a9675a630a01988cd30679c7409e123292ae/src/master/master.cpp#L794 We should use that value here. Agreed? I'll add a minimum. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20502/#review41043 ----------------------------------------------------------- On April 21, 2014, 10:10 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20502/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 10:10 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-982 > https://issues.apache.org/jira/browse/MESOS-982 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/constants.hpp 6d1cfda97162f9f332e7f92461b281035587e7fa > src/slave/constants.cpp 9811bd39e352a5097eaadb3ae6c6e4f43bc9cd98 > src/slave/slave.hpp 438e5b58d732862b3ca1de10f2aabbf5d9071584 > src/slave/slave.cpp b3c428508c77bf1ca9154f9c22b5d83c27bc9d1e > > Diff: https://reviews.apache.org/r/20502/diff/ > > > Testing > ------- > > make check. Also tested the random backoff logic separately. > > > Thanks, > > Jiang Yan Xu > >
