> On April 21, 2014, 2:47 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 624 > > <https://reviews.apache.org/r/20502/diff/1/?file=562543#file562543line624> > > > > s/backoffInterval/duration/ to be consistent with how we named it in > > status update manager.
I will make the change to keep our naming consistent but I have my reservations about naming variables less descriptively. void Slave::doReliableRegistration(const Duration& duration); vs. void Slave::doReliableRegistration(const Duration& backoffInterval); Seems like the latter reads better and is self-documenting. Maybe this should be discussed elsewhere so I am fine with these suggested renaming in this review. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20502/#review40953 ----------------------------------------------------------- On April 20, 2014, 2:49 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20502/ > ----------------------------------------------------------- > > (Updated April 20, 2014, 2:49 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-982 > https://issues.apache.org/jira/browse/MESOS-982 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 1e9879582315fabb76659e9f8eb03f90188fbfa0 > src/slave/slave.cpp d6ec87c2232c2172f471ae30711b5da1c7050570 > > Diff: https://reviews.apache.org/r/20502/diff/ > > > Testing > ------- > > make check. Also tested the random backoff logic separately. > > > Thanks, > > Jiang Yan Xu > >
