> On April 21, 2014, 2:47 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 738 > > <https://reviews.apache.org/r/20502/diff/1/?file=562543#file562543line738> > > > > Why 16 seconds? Seems too low of a value? How about 10 min like we did > > for status updates? > > > > Either way pull this out to a constant (e.g., SLAVE_RETRY_INTERVAL_MAX). > > Jiang Yan Xu wrote: > We do want them to register prior to the 75 second time out right? > > Vinod Kone wrote: > oh yea thats right. s/10min/75s/. Ideally we should extract out the slave > ping timeout and max ping retries into a common/constants.hpp header so that > it can be used by both the master and slave. maybe a TODO for now.
Instead of TODO, will follow up with a review for it. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20502/#review40953 ----------------------------------------------------------- On April 21, 2014, 10:10 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20502/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 10:10 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-982 > https://issues.apache.org/jira/browse/MESOS-982 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/constants.hpp 6d1cfda97162f9f332e7f92461b281035587e7fa > src/slave/constants.cpp 9811bd39e352a5097eaadb3ae6c6e4f43bc9cd98 > src/slave/slave.hpp 438e5b58d732862b3ca1de10f2aabbf5d9071584 > src/slave/slave.cpp b3c428508c77bf1ca9154f9c22b5d83c27bc9d1e > > Diff: https://reviews.apache.org/r/20502/diff/ > > > Testing > ------- > > make check. Also tested the random backoff logic separately. > > > Thanks, > > Jiang Yan Xu > >
