> On April 22, 2014, 6:10 p.m., Ben Mahler wrote: > > src/master/registrar.cpp, lines 87-88 > > <https://reviews.apache.org/r/20581/diff/3/?file=564996#file564996line87> > > > > Looks like this needs a rebase, but how about introducing an unnamed > > struct in Registrar so we can do: > > > > timers.fetch > > timers.store > > > > gauges.queued_operations > > > > Akin to what we did for 'stats' and 'slaves' in Master.
It adds complications: It would need a default constructor, and then the Gauge is no longer defering to 'self()' but to the outer process. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20581/#review41104 ----------------------------------------------------------- On April 22, 2014, 8:03 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20581/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 8:03 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added Timers for state store/fetch and a Gauge to track the length of the > operations queue. > > > Diffs > ----- > > src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 > > Diff: https://reviews.apache.org/r/20581/diff/ > > > Testing > ------- > > local build + mesos-local.sh + manual inspection. > make check. > > > Thanks, > > Dominic Hamon > >
