> On April 23, 2014, 11:17 a.m., Ben Mahler wrote: > > src/master/registrar.cpp, lines 148-151 > > <https://reviews.apache.org/r/20581/diff/4/?file=565299#file565299line148> > > > > Would love to see some structs here (we can name them and add > > constructors if necessary) > > > > struct Timers > > { > > Timer state_fetch; > > Timer state_store; > > } timers; > > > > struct Gauges > > { > > Gauge queued_operations; > > } gauges; > > > > It seems that we should make an exception here and use snake_case so > > that we match the names of the metrics as they are exposed in the endpoint?
This slightly complicates the gauge construction as the struct doesn't have access to the access method for the operations queue size. I'll put up a patch with this so you can see what's necessary and compare. Also - naming exceptions as a policy for metrics seem like the thin end of a wedge. I don't think it's onerous to search for a metric name and find the variable being constructed. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20581/#review41173 ----------------------------------------------------------- On April 22, 2014, 8:03 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20581/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 8:03 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added Timers for state store/fetch and a Gauge to track the length of the > operations queue. > > > Diffs > ----- > > src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 > > Diff: https://reviews.apache.org/r/20581/diff/ > > > Testing > ------- > > local build + mesos-local.sh + manual inspection. > make check. > > > Thanks, > > Dominic Hamon > >
