----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20581/#review41173 -----------------------------------------------------------
src/master/registrar.cpp <https://reviews.apache.org/r/20581/#comment74580> Would love to see some structs here (we can name them and add constructors if necessary) struct Timers { Timer state_fetch; Timer state_store; } timers; struct Gauges { Gauge queued_operations; } gauges; It seems that we should make an exception here and use snake_case so that we match the names of the metrics as they are exposed in the endpoint? - Ben Mahler On April 23, 2014, 3:03 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20581/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 3:03 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added Timers for state store/fetch and a Gauge to track the length of the > operations queue. > > > Diffs > ----- > > src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 > > Diff: https://reviews.apache.org/r/20581/diff/ > > > Testing > ------- > > local build + mesos-local.sh + manual inspection. > make check. > > > Thanks, > > Dominic Hamon > >
